-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'remove-slow-upload-seeds' and 'remove-fast-upload-seeds' to remove torrents with slower or faster upload speed #127
Add 'remove-slow-upload-seeds' and 'remove-fast-upload-seeds' to remove torrents with slower or faster upload speed #127
Conversation
Add 'remove-slow-upload-seeds' to 'action' keyword in order to remove torrents with slower upload speed. 添加'remove-slow-upload-seeds'到'action'关键字, 从而能够删除慢速上传的种子. Example: limit_max_torrents: status: - downloading maximum_number: limit: 30 action: remove-slow-upload-seeds
感谢你的PR,很有用的功能,可以合并。不过在合并之前,我想请你再补充一些代码:
|
感谢反馈,会跟进相关内容,估计要到本周末。 |
问一下,因为之前没用过pytest,reference data那里也要准备吗? 看了一下cases里面有提到 - Torrent - 数字,这里应该是指reference data里面的种子名对吧? |
不用,种子的测试数据已经准备好了,只需根据测试数据找出会删除的种子即可。另外在这里我有个小失误,测试数据其实是在
对的 |
…ction keyword b) added unit test cases accordingly
hi my apologizes.. I have forgot about this PR for quite some time. I have further added remove-fast-upload-seeds, as well as the unit test cases. Everything turns out to be good. Please review. ================================================================================ test session starts ================================================================================= test_strategies.py . [100%] ================================================================================= 1 passed in 3.82s ================================================================================== |
LGTM. Thank you for your contribution! |
Thanks for update. In terms of user experiences, I will further create a PR to cover 'remove-fast-download-seeds' and 'remove-slow-download-seeds'. Stay tuned. |
Good. Looking forward for to your new PR. 😄 |
I'm afraid there is typo here... 906 --> 806 |
Add 'remove-slow-upload-seeds' to 'action' keyword in order to remove torrents with slower upload speed.
添加'remove-slow-upload-seeds'到'action'关键字, 从而能够删除慢速上传的种子.
Example: