Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redable stream 'end' event emitting and object lost on net socket. #106

Closed
wants to merge 3 commits into from
Closed

Fix redable stream 'end' event emitting and object lost on net socket. #106

wants to merge 3 commits into from

Conversation

ILyoan
Copy link
Contributor

@ILyoan ILyoan commented Jun 29, 2015

This PR correct two pitfalls.

@ILyoan
Abort on jerry fatal exception
59e285a 
IoT.js-DCO-1.0-Signed-off-by: Ilyong Cho ily.cho@samsung.com
@ILyoan
Correct emitting 'end' event of readable stream.
e26049c 
IoT.js-DCO-1.0-Signed-off-by: Ilyong Cho ily.cho@samsung.com
@ILyoan
Hold sockets create by server as long as the socket alive
d45a84f 
IoT.js-DCO-1.0-Signed-off-by: Ilyong Cho ily.cho@samsung.com
@ILyoan
Copy link
Contributor Author

ILyoan commented Jun 29, 2015

Fix for #104

@ILyoan ILyoan mentioned this pull request Jun 29, 2015
Closed
@seanshpark
Copy link
Contributor

LGTM

@ILyoan
Copy link
Contributor Author

ILyoan commented Jun 29, 2015

Merged

@ILyoan ILyoan closed this Jun 29, 2015
@ILyoan ILyoan deleted the fix_redable_net branch June 29, 2015 05:20
@ILyoan ILyoan mentioned this pull request Jun 29, 2015
Closed
pmarcinkiew referenced this pull request in pmarcinkiew/iotjs Aug 29, 2017
@sunghan-chang
Merge pull request #106 from jeongarmy/kdbg_uptime
f99f71a 
Add uptime to TASH commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird behavior that comment matters what's happening.
2 participants
@ILyoan @seanshpark