Add arm-linux build for RPi2 and fix for nuttx build #125
Conversation
| CMAKE_FORCE_C_COMPILER(${EXTERNAL_CMAKE_C_COMPILER} GNU) | ||
| CMAKE_FORCE_CXX_COMPILER(${EXTERNAL_CMAKE_CXX_COMPILER} GNU) | ||
|
|
||
| set(DEVICE_DEPENDS "linux-arm-rpi2") |
There was a problem hiding this comment.
Isn't this file for "arm-linux" ?
Specifying "rpi2" in this file seems not appropriate.
There was a problem hiding this comment.
some where we need to specify rpi2 cause of gpio
There was a problem hiding this comment.
That true but I don't think this file is correct place.
There was a problem hiding this comment.
ok, do you have a place in mind? I can change.
|
I think we need to discuss GPIO API in #110. |
|
We have gpio api for example, 'gpio.write(pin, data, callback). |
yes, for STM32, explicit set data to 0 or 1 seems better to match digital I/O. the code is as is for analog value (0~255) also, that may not be same as RPi2. |
seanshpark
changed the title
|
Changed this PR to reflect #122(jerryscript-project/jerryscript#330) and jerryscript-project/jerryscript#345. |
| if(${CFG_SYS_PROCESSOR} STREQUAL "x86" OR | ||
| ${CFG_SYS_PROCESSOR} STREQUAL "x86_64") | ||
| set(DEVICE_DEPENDS "linux-x86") | ||
| elseif(${CFG_SYS_PROCESSOR} STREQUAL "armv7l-hf") |
There was a problem hiding this comment.
"armv7l-hf" just tells us the cpu architecture, we could not determine that this is Raspberry PI2 ?
There was a problem hiding this comment.
yes, we need board dependent implementation. at this time there is only one arm-linux and it's RPi2, but later there might be others. I'm not sure about how to extend this right now. I hope you can give a way to do this.
|
board specific names are removed. when implementation differs we can add compile directives. |
IoT.js-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@samsung.com
|
@seanshpark OK thanks. I see numbers likely are different from board to board even if we use the same implementation for different boards so we need board directive as you mentioned. I'll modify build script for adding board directive. |
|
@seanshpark I think last commit is enough to be merged. as we can adjust trivial issues from following updates. Let's make it merged. |
Added functions to read RSSI and IP address into LWM2M connectivity o…
IoT.js-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@samsung.com
also fix for nuttx build, as jerry has removed nuttx and fixed to use external.