Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to IOTJS_ALLOC instead of malloc #1280

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

hs0225
Copy link
Contributor

@hs0225 hs0225 commented Oct 24, 2017

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
Copy link
Member

@daeyeon daeyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi
Copy link
Contributor

yichoi commented Oct 24, 2017

LGTM

@yichoi yichoi merged commit dc60733 into jerryscript-project:master Oct 24, 2017
@glistening
Copy link
Contributor

glistening commented Oct 24, 2017

void iotjs_gpio_platform_destroy(iotjs_gpio_t_impl_t* _this) {
   iotjs_buffer_release((char*)_this->platform);
}

Please change iotjs_buffer_release to IOTJS_RELEASE in xxx_destroy.

hs0225 added a commit to hs0225/iotjs that referenced this pull request Oct 24, 2017
changed for code consistency
reflect the comment of glistening in jerryscript-project#1280

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
hs0225 added a commit to hs0225/iotjs that referenced this pull request Oct 24, 2017
changed for code consistency
reflect the comment of glistening in jerryscript-project#1280

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
hs0225 added a commit to hs0225/iotjs that referenced this pull request Oct 24, 2017
changed for code consistency
reflect the comment of glistening in jerryscript-project#1280

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
@LaszloLango
Copy link
Contributor

I think this will fix jerryscript-project/js-remote-test#44

yichoi pushed a commit that referenced this pull request Oct 24, 2017
changed for code consistency
reflect the comment of glistening in #1280

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
pmarcinkiew pushed a commit to pmarcinkiew/iotjs that referenced this pull request Nov 17, 2017
IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
pmarcinkiew pushed a commit to pmarcinkiew/iotjs that referenced this pull request Nov 17, 2017
changed for code consistency
reflect the comment of glistening in jerryscript-project#1280

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
pmarcinkiew pushed a commit to pmarcinkiew/iotjs that referenced this pull request Nov 17, 2017
IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
pmarcinkiew pushed a commit to pmarcinkiew/iotjs that referenced this pull request Nov 17, 2017
changed for code consistency
reflect the comment of glistening in jerryscript-project#1280

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
rzr pushed a commit to TizenTeam/iotjs that referenced this pull request Mar 14, 2018
IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
rzr pushed a commit to TizenTeam/iotjs that referenced this pull request Mar 14, 2018
changed for code consistency
reflect the comment of glistening in jerryscript-project#1280

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants