-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to IOTJS_ALLOC instead of malloc #1280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
daeyeon
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Please change |
hs0225
added a commit
to hs0225/iotjs
that referenced
this pull request
Oct 24, 2017
changed for code consistency reflect the comment of glistening in jerryscript-project#1280 IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
hs0225
added a commit
to hs0225/iotjs
that referenced
this pull request
Oct 24, 2017
changed for code consistency reflect the comment of glistening in jerryscript-project#1280 IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
hs0225
added a commit
to hs0225/iotjs
that referenced
this pull request
Oct 24, 2017
changed for code consistency reflect the comment of glistening in jerryscript-project#1280 IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
I think this will fix jerryscript-project/js-remote-test#44 |
yichoi
pushed a commit
that referenced
this pull request
Oct 24, 2017
changed for code consistency reflect the comment of glistening in #1280 IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
pmarcinkiew
pushed a commit
to pmarcinkiew/iotjs
that referenced
this pull request
Nov 17, 2017
IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
pmarcinkiew
pushed a commit
to pmarcinkiew/iotjs
that referenced
this pull request
Nov 17, 2017
changed for code consistency reflect the comment of glistening in jerryscript-project#1280 IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
pmarcinkiew
pushed a commit
to pmarcinkiew/iotjs
that referenced
this pull request
Nov 17, 2017
IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
pmarcinkiew
pushed a commit
to pmarcinkiew/iotjs
that referenced
this pull request
Nov 17, 2017
changed for code consistency reflect the comment of glistening in jerryscript-project#1280 IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
rzr
pushed a commit
to TizenTeam/iotjs
that referenced
this pull request
Mar 14, 2018
IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
rzr
pushed a commit
to TizenTeam/iotjs
that referenced
this pull request
Mar 14, 2018
changed for code consistency reflect the comment of glistening in jerryscript-project#1280 IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com