Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emitting end and finish event of duplex stream more properly #144

Merged
merged 1 commit into from
Jul 29, 2015
Merged

Emitting end and finish event of duplex stream more properly #144

merged 1 commit into from
Jul 29, 2015

Conversation

ILyoan
Copy link
Contributor

@ILyoan ILyoan commented Jul 28, 2015

This commit fixes two problems

  1. In some situation 'end' event was not emitted from the first place.
  2. In some situation 'end` event was lost because the socket closed before triggering 'end' listener.

@ILyoan
Emitting end and finish event of duplex stream more properly
e8387a7 
IoT.js-DCO-1.0-Signed-off-by: Ilyong Cho ily.cho@samsung.com
@chunseoklee
Copy link
Contributor

LGTM lets push

@chunseoklee chunseoklee merged commit e8387a7 into jerryscript-project:master Jul 29, 2015
@ILyoan ILyoan deleted the duplex_ending branch July 29, 2015 02:23
@ILyoan ILyoan mentioned this pull request Aug 3, 2015
Closed
pmarcinkiew referenced this pull request in pmarcinkiew/iotjs Aug 29, 2017
@Taejun-Kwon
Merge pull request #144 from dr-venkman/master
7ce379b 
Fixed build error in DM testcase, incorrect variable naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ILyoan @chunseoklee