tizenrt: Relocate downstream Makefile to config dir (along Kconfig) #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
043a0a7
to
aec2d20
Compare
|
IoT.js supports the latest public release of TizenRT. And, our TravisCI verifies each PR with the version as follow. https://github.com/Samsung/iotjs/blob/44cda4095d838ab3c89fb7fc45ad7ad5a001ef09/tools/travis_script.py#L45 This commit is based on the branch assumed as a development branch. That means this commit will never be tested in our current TravisCI environment. We need an official release tag when discussing upgrading IoT.js snapshot for each target. |
|
Ok I understand your valid point , but aren't we in a chicken and egg situation ? Meanwhile it can be applied downstream... Anyway this change should be harmless to your current test env. |
|
In the maintenance perspective, this isn't the case you told. |
Closed
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Sep 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 5, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 6, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 10, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 18, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 22, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 22, 2018
Because current version of TizenRT in IoT.js docker image is oudated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. Use iotjs's defconfig as default config instead of file: "tizenrt_release_config" from container: https://hub.docker.com/r/iotjs/ubuntu/ Is this file tracked anywhere? Later debug, release configs can tracked in IoT.js's source tree, and used as desired, for performance benchmarking. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgrade IoT.js ?) Bug: jerryscript-project#1777 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com Disable debuger code if not enabled Observed build issue on TizenRT (master): iotjs.c:58: undefined reference to `jerryx_debugger_tcp_create' iotjs.c:59: undefined reference to `jerryx_debugger_ws_create' iotjs.c:58: undefined reference to `jerryx_debugger_after_connect' The whole part is disabled, even if only jerry-ext functions are not linked (on Tizen:RT master). Change-Id: Id88c745c9712f6f620bbd200f493397572174ce6 Forwarded: jerryscript-project#1749 Origin: https://github.com/TizenTeam/iotjs/ IoT.js-DCO-1.0-Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com tizenrt: Update defconfig from TizenRT 2.0 Align to TizenRT default config, but disable SSS for ARTIK053 Bug: jerryscript-project#1777 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com tizenrt: Relocate downstream Makefile to config dir (along Kconfig) [Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 22, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 25, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to rzr/iotjs
that referenced
this pull request
Nov 8, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 12, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 12, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 13, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 15, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 27, 2018
[Philippe Coval] After some (recent) refactoring in build script, This file was over imported iotjs module in TizenRT. Like done previously with Kconfig file, it will be better to minimize downstream patches. One benefit to have those build related files, is that then IoT.js can be upgraded into TizenRT by just cloning iotjs's again into subdir: TizenRT/external/iotjs Note: Extra minor changes has been done over TizenRT's patch to make some options overridable from env var (profile file...) [Sunghan Chang] Makefile: move IoT.js-specific build step to IoT.js folder Because Makefile.unix has TizenRT-common build step, it is not good including IoT.js-specific step. Let's add Makefile in IoT.js and execute all of step in it. Thanks-to: sunghan-chang <sh924.chang@samsung.com> Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240 Bug-TizenRT: Samsung/TizenRT#2111 Origin: Samsung/TizenRT@bbd3cdb Relate-to: jerryscript-project#1726 Forwarded: jerryscript-project#1732 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Philippe Coval]
After some (recent) refactoring in build script,
This file was over imported iotjs module in TizenRT.
Like done previously with Kconfig file,
it will be better to minimize downstream patches.
One benefit to have those build related files,
is that then IoT.js can be upgraded into TizenRT
by just cloning iotjs's again into subdir:
TizenRT/external/iotjs
Note: Extra minor changes has been done over TizenRT's patch
to make some options overridable from env var (profile file...)
[Sunghan Chang]
Makefile: move IoT.js-specific build step to IoT.js folder
Because Makefile.unix has TizenRT-common build step,
it is not good including IoT.js-specific step.
Let's add Makefile in IoT.js and execute all of step in it.
Thanks-to: sunghan-chang sh924.chang@samsung.com
Change-Id: Iddeb272dc6ad6c283ccad9f92bf02754f9ba3240
Bug-TizenRT: Samsung/TizenRT#2111
Origin: Samsung/TizenRT@bbd3cdb
Relate-to: #1726
Forwarded: https://github.com/Samsung/iotjs
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com