Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce mock linux platform for GPIO testing on Travis CI #1775

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Introduce mock linux platform for GPIO testing on Travis CI #1775

merged 1 commit into from
Oct 23, 2018

Conversation

LaszloLango
Copy link
Contributor

@LaszloLango LaszloLango commented Oct 16, 2018 •
edited

Related issue: #1779

IoT.js-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com

@LaszloLango LaszloLango force-pushed the mock-testing branch 3 times, most recently from 1891f25 to d518492 Compare October 16, 2018 13:55
@LaszloLango
Copy link
Contributor Author

This is a proof of concept patch. IMHO it can help to catch bugs on the CI before patches merging. I know it is not equal to testing on real hardware. Although it revealed a few issues in the GPIO module. You can see the commented test cases in the newly added test/run_pass/test_gpio_api.js. If we accept this patch then we can do the same for i2c, adc, pwm and spi (maybe for uart too). I think this patch can help to maintain the peripheral modules and makes the them more stable. Bugs like #1768 (caused by #1739) could be caught on the CI with this patch.

@daeyeon @hs0225 what do you think about this approach (peripheral mocking)?

@hs0225
Copy link
Contributor

hs0225 commented Oct 19, 2018

@LaszloLango I agree with this PR. Although this does not test on the target, it is expected to catch some issues about API.

@LaszloLango LaszloLango mentioned this pull request Oct 19, 2018
Open
5 tasks
@LaszloLango
Introduce mock linux platform for GPIO testing on Travis CI
1c825c3 
Related issue: jerryscript-project#1779

IoT.js-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
@LaszloLango LaszloLango changed the title [WIP] Introduce mock linux platform for GPIO testing on Travis CI Introduce mock linux platform for GPIO testing on Travis CI Oct 19, 2018
daeyeon
daeyeon approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@daeyeon daeyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daeyeon
daeyeon approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@daeyeon daeyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hs0225
hs0225 approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@hs0225 hs0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hs0225
hs0225 approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@hs0225 hs0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit 474dcd4 into jerryscript-project:master Oct 23, 2018
@LaszloLango LaszloLango deleted the mock-testing branch November 15, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeyeon daeyeon daeyeon approved these changes

@hs0225 hs0225 hs0225 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LaszloLango @hs0225 @daeyeon @yichoi