Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified function and variable names in C source codes. #1881

Merged
merged 1 commit into from May 21, 2019

Conversation

LaszloLango
Copy link
Contributor

'CamelCase' and 'underscore_case' were mixed together, but
'unerscores_case' should be used always for function and
variable names in the C codes. Most of the exiting code path
used underscores. This patch fixes the remained wrong cases.

IoT.js-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com

@LaszloLango
Copy link
Contributor Author

@rtakacs @Yuyupo could you test this PR on the supported devices?

@pmarkee
Copy link
Contributor

pmarkee commented May 20, 2019

I have tried peripheral (gpio, i2c etc) tests on rpi2+Linux, it runs the same as the current master, so this patch should be fine.

@LaszloLango LaszloLango changed the title [WIP] Unified function and variable names in C source codes. Unified function and variable names in C source codes. May 20, 2019
@LaszloLango LaszloLango requested a review from hs0225 May 20, 2019 08:14
'CamelCase' and 'underscore_case' were mixed together, but
'unerscores_case' should be used always for function and
variable names in the C codes. Most of the exiting code path
used underscores. This patch fixes the remained wrong cases.

IoT.js-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
Copy link
Contributor

@hs0225 hs0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit a7f94f9 into jerryscript-project:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants