Fix bug in 64bit -> 32bit cross build #271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-build 32bit version iotjs in 64bit host, the
./tools/build.py --target-arch=i686
will not succeed, because the "-m32" or "-march=i686" flag is not set in thecmake/config/i686-linux.cmake
.This patch fixs the bug.
1, add "-m32" or "-march=i686" flag in i686-linux.cmake
2, libuv is built by gyp. So we modified the
tools/build.py
to pass the target_arch to the gyp_uv3, libtuv use the
opt_cmake_toolchain_file()
as its CMAKE_TOOLCHAIN_FILE, like other dep_modules did. so libtuv can also support i686 cross-build.