Add jerry fdlibm library in build script #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2015
IoT.js-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@samsung.com
| @@ -361,6 +367,72 @@ def build_libjerry(): | |||
| mkdir(opt_build_libs()) | |||
| copy(build_cache_path, libjerry_output_path()) | |||
|
|
|||
| # fdlibm for nuttx | |||
| if check_build_libjerryfdlibm(): | |||
There was a problem hiding this comment.
Could we separate this "if" block as another function?
There was a problem hiding this comment.
Also, does fdlib depends on jerry? if not, we don't need to call it "jerryfdlibm" just "fdlibm" is ok and not confusing.
There was a problem hiding this comment.
On second thought, another build phase is unnecessary we can build "libjerry" and "fdlibm" at one time together by feeding both build target for make command.
There was a problem hiding this comment.
make -C /home/maxwell/harmony/iotjs/build/arm-nuttx/debug/deps/jerry debug.jerry-core debug.jerry-fdlibm.third_party.lib -j1
make: Entering directory `/home/maxwell/harmony/iotjs/build/arm-nuttx/debug/deps/jerry'
make: *** No rule to make target `debug.jerry-core debug.jerry-fdlibm.third_party.lib'. Stop.
maybe another way?
|
@ILyoan , I'm not sure about this build.py changes. What is needed is libfdlibm.a file with |
|
drop this, issue #55 added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IoT.js-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@samsung.com