Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native callback with object gc #2

Closed
seanshpark opened this issue Apr 28, 2015 · 2 comments
Closed

native callback with object gc #2

seanshpark opened this issue Apr 28, 2015 · 2 comments
Assignees
@seanshpark
Labels
enhancement An improvement

Comments

@seanshpark
Copy link
Contributor

I'm adding this issue to discuss in open so may help others to understand and join (to the issues)

Codes can be efficient if some native function is called when JS Object is garbage collected so that some block of memory linked to that Object can be freed. Something like MakeWeak in V8.

API something like this;

typedef bool (*jerry_object_free_callback_t) (const jerry_api_object_t* obj);
bool jerry_api_set_objectfreecb(jerryt_api_object_t* obj, jerry_object_free_callback_t handler_p);
@seanshpark seanshpark added the enhancement An improvement label Apr 28, 2015
@seanshpark seanshpark self-assigned this Apr 28, 2015
seanshpark added a commit that referenced this issue Apr 28, 2015
@seanshpark
inital code for object free callback, issue #2
48cc9b5 
JerryScript-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@samsung.com
@seanshpark
Copy link
Contributor Author

had to remove unwanted(wrong DCO) branch
hope 48cc9b5 will do.

seanshpark added a commit that referenced this issue Apr 28, 2015
@seanshpark
object free callback fix, issue #2
130e627 
- remove jerry_api_get_object_free_callback(), currenly no usage
- remove object_p parameter with free_callback(), object can mislead users to call APIs which is dangerous this time.

JerryScript-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@samsung.com
@seanshpark
Copy link
Contributor Author

5ec3e2f merged to master

sand1k referenced this issue in sand1k/jerryscript Nov 23, 2015
@ruben-ayrapetyan
Merge pull request #2 from sand1k/statements_parse
cc21951 
Add initial statement parsing support.
@huxinx huxinx mentioned this issue Jan 8, 2016
Closed
ktorpi added a commit to ktorpi/jerryscript that referenced this issue Jun 1, 2016
@ktorpi
API documentation update jerryscript-project#2
1f30fc1 
Function descriptions and examples are added to API page.

JerryScript-DCO-1.0-Signed-off-by: István Kádár ikadar@inf.u-szeged.hu
ktorpi added a commit to ktorpi/jerryscript that referenced this issue Jun 6, 2016
@ktorpi
API documentation update jerryscript-project#2
3008ab6 
Function descriptions and examples are added to API page.

JerryScript-DCO-1.0-Signed-off-by: István Kádár ikadar@inf.u-szeged.hu
LaszloLango added a commit to LaszloLango/jerryscript that referenced this issue Jul 6, 2016
@LaszloLango
Addressing reviews and minor fixes jerryscript-project#2
5a594dd 
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
polaroi8d referenced this issue in polaroi8d/jerryscript Aug 29, 2016
update #2
2377765
polaroi8d referenced this issue in polaroi8d/jerryscript Oct 18, 2016
Typo fix.. #2
caeb563
polaroi8d referenced this issue in polaroi8d/jerryscript Oct 24, 2016
initial #2
40ccc62
@tadziopazur tadziopazur mentioned this issue Apr 18, 2017
Closed
@JeffJerseyCow JeffJerseyCow mentioned this issue May 30, 2017
Closed
This was referenced Aug 17, 2017
Closed
Closed
Closed
Closed
Closed
Closed
@zhunki zhunki mentioned this issue Dec 7, 2017
Closed
grgustaf pushed a commit to grgustaf/jerryscript that referenced this issue Feb 23, 2018
@martijnthe
Merge pull request jerryscript-project#2 from grgustaf/jdp-handle-ini…
3fec1d0 
…tial-apis

handle initial flurry of json apis w/o errors
@zhunki zhunki mentioned this issue Mar 1, 2018
Closed
@zhunki zhunki mentioned this issue Mar 8, 2018
Closed
galpeter added a commit to galpeter/jerryscript that referenced this issue Jun 8, 2018
@galpeter
Improve license checker line ending validation
4dad260 
The license checker previously assumed that the
lines of the license will always end with \n
characters. However when checking a file
with \r\n line endings (should only happen for test files)
the checker can incorrectly report invalid license
as the line endings are incorrect.

Additional note jerryscript-project#1: in Python when reading a file
in text mode it can happen that the line endings are
converted to the host system's line ending.
That is the `\r\n` will be converted to `\n` on Linux.
To resolve this problem the io module to disable
the line ending conversion.

Additional note jerryscript-project#2: it is possible that there
are input test files which are not utf-8 conformant
(eg.: to test the parser). These files can't be read
as utf-8 strings and an exception would occur.
By ignoring these errors the tool can check
the file's license. In the license text there is no
invalid utf-8 character so the check will work
correctly.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
@galpeter galpeter mentioned this issue Jun 8, 2018
Merged
galpeter added a commit to galpeter/jerryscript that referenced this issue Jun 11, 2018
@galpeter
Improve license checker line ending validation
60a3c33 
The license checker previously assumed that the
lines of the license will always end with \n
characters. However when checking a file
it could happen that other line endings are
returned (should only happen for test files) thus
the checker can incorrectly report invalid license
as the line endings are incorrect.

Additional note jerryscript-project#1: in Python when reading a file
in text mode it can happen that the line endings are
converted to the host system's line ending.
However on Travis the conversion did not happen when
using the open built-in method. By switching to the
io.open call the conversion is enforced and
all line endings are converted to '\n' regardless of
the host system's line ending.

Additional note jerryscript-project#2: it is possible that there
are input test files which are not utf-8 conformant
(eg.: to test the parser). These files can't be read
as utf-8 strings and an exception would occur.
By ignoring these errors the tool can check
the file's license. In the license text there is no
invalid utf-8 character so the check will work
correctly.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
yichoi pushed a commit that referenced this issue Jun 11, 2018
@galpeter @yichoi
Improve license checker line ending validation (#2391)
9ae60a4 
The license checker previously assumed that the
lines of the license will always end with \n
characters. However when checking a file
it could happen that other line endings are
returned (should only happen for test files) thus
the checker can incorrectly report invalid license
as the line endings are incorrect.

Additional note #1: in Python when reading a file
in text mode it can happen that the line endings are
converted to the host system's line ending.
However on Travis the conversion did not happen when
using the open built-in method. By switching to the
io.open call the conversion is enforced and
all line endings are converted to '\n' regardless of
the host system's line ending.

Additional note #2: it is possible that there
are input test files which are not utf-8 conformant
(eg.: to test the parser). These files can't be read
as utf-8 strings and an exception would occur.
By ignoring these errors the tool can check
the file's license. In the license text there is no
invalid utf-8 character so the check will work
correctly.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
@dominiakm dominiakm mentioned this issue Jul 24, 2018
Closed
@renatahodovan renatahodovan mentioned this issue Aug 27, 2018
Closed
ossy-szeged added a commit to ossy-szeged/jerryscript that referenced this issue Oct 24, 2019
@ossy-szeged
# This is a combination of 6 commits.
301d7f1 
# This is the 1st commit message:

python runner for jerry-tests and jerry-test-suite

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu

# The commit message jerryscript-project#2 will be skipped:

# JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
# more fixes

# The commit message jerryscript-project#3 will be skipped:

# win fixes
#
# JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu

# The commit message jerryscript-project#4 will be skipped:

# x

# The commit message jerryscript-project#5 will be skipped:

# revert accidentail change

# The commit message jerryscript-project#6 will be skipped:

# lf
@anonpoet anonpoet mentioned this issue May 7, 2020
Closed
@vulsReport vulsReport mentioned this issue May 13, 2020
Closed
This was referenced May 17, 2020
Closed
Closed
Closed
Closed
This was referenced Jun 5, 2020
Closed
Closed
Closed
@ruc-fuzzer ruc-fuzzer mentioned this issue Sep 14, 2020
Closed
@paintedveil5 paintedveil5 mentioned this issue Sep 29, 2020
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
@Symatrix6 Symatrix6 mentioned this issue Oct 13, 2021
Closed
@Symatrix6 Symatrix6 mentioned this issue Nov 24, 2021
Closed
@bmphx2 bmphx2 mentioned this issue Mar 3, 2023
Open
@marckwei marckwei mentioned this issue Mar 28, 2023
Open
This was referenced Apr 6, 2023
Open
Open
@Limesss Limesss mentioned this issue May 10, 2023
Open
@paintedveil5 paintedveil5 mentioned this issue Apr 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanshpark seanshpark

Labels
enhancement An improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanshpark