Implement Object.create function #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkristof
added
ecma builtins
21 tasks
| // is equivalent to: | ||
| var o2 = Object.create(Object.prototype); | ||
|
|
||
| //assert (o1 === o2); |
|
Hi, I have updated the patch. |
| @@ -28,6 +28,7 @@ | |||
|
|
|||
| extern ecma_object_t* ecma_op_create_object_object_noarg (void); | |||
| extern ecma_completion_value_t ecma_op_create_object_object_arg (ecma_value_t value); | |||
| extern ecma_object_t* ecma_op_create_object_object_noarg_and_set_prototype (ecma_object_t *object_prototype_p); | |||
There was a problem hiding this comment.
Please align the * to the function name.
|
aside from the minor style comments it looks good to me. |
| @@ -62,7 +62,7 @@ ecma_op_create_object_object_noarg (void) | |||
| ecma_object_t *object_prototype_p = ecma_builtin_get (ECMA_BUILTIN_ID_OBJECT_PROTOTYPE); | |||
|
|
|||
| // 3., 4., 6., 7. | |||
| ecma_object_t *obj_p = ecma_create_object (object_prototype_p, true, ECMA_OBJECT_TYPE_GENERAL); | |||
| ecma_object_t *obj_p = ecma_op_create_object_object_noarg_and_set_prototype (object_prototype_p); | |||
|
|
|||
| ecma_deref_object (object_prototype_p); | |||
|
|
|||
There was a problem hiding this comment.
Could you, please, move the comment about [[Class]] below to ecma_op_create_object_object_noarg_and_set_prototype?
JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo kkosztyo.u-szeged@partner.samsung.com
|
Hi, I have updated the patch. |
|
Looks good to me. |
|
|
|
Rebased & merged: 61ab205 |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo kkosztyo.u-szeged@partner.samsung.com