New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Number.prototype.toExponential() #224
Implement Number.prototype.toExponential() #224
Conversation
|
||
if (!ecma_is_value_undefined (arg)) | ||
{ | ||
frac_digits = ecma_number_to_int32 (arg_num); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ToNumber
returns NaN
for undefined
, and ToInt32
returns zero for NaN
.
s *= 10; | ||
} | ||
|
||
ecma_char_t* p = buff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong placed *
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
I've updated the PR, please take a look. |
lgtm |
@egavrin, @ruben-ayrapetyan , any other comments? |
@dbatyai, I've got no other comments. |
Good to me |
merged: 53cbb55 |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com