Skip to content

Implement Number.prototype.toPrecision() #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implement Number.prototype.toPrecision() #238

wants to merge 1 commit into from

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented Jun 25, 2015

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com

@dbatyai dbatyai added ecma builtins Related to ECMA built-in routines development Feature implementation labels Jun 25, 2015
@dbatyai dbatyai added this to the ECMA builtins milestone Jun 25, 2015
@galpeter galpeter mentioned this pull request Jun 25, 2015
Closed
16 tasks
egavrin
egavrin reviewed Jun 25, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-number-prototype.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add magic string for this?

@egavrin
Copy link
Contributor

egavrin commented Jun 25, 2015

Good to me.

@egavrin egavrin assigned ruben-ayrapetyan and unassigned dbatyai Jun 25, 2015
@ruben-ayrapetyan
Copy link
Contributor

Looks good to me.

kkristof
kkristof reviewed Jun 25, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-number-prototype.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two space: exponent < -5

@egavrin
Copy link
Contributor

egavrin commented Jun 25, 2015

make push, after fixing

@galpeter galpeter assigned kkristof and unassigned galpeter Jun 25, 2015
@dbatyai
Implement Number.prototype.toPrecision()
64d57c5 
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
@kkristof
Copy link
Contributor

lgtm

@egavrin
Copy link
Contributor

egavrin commented Jun 30, 2015

make push

@egavrin egavrin assigned dbatyai and unassigned kkristof Jun 30, 2015
@dbatyai
Copy link
Member Author

dbatyai commented Jul 1, 2015

merged: 713b433

@dbatyai dbatyai closed this Jul 1, 2015
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
@owl337 owl337 mentioned this pull request May 17, 2020
Closed
@owl337 owl337 mentioned this pull request May 18, 2020
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dbatyai dbatyai

Labels
development Feature implementation ecma builtins Related to ECMA built-in routines
Projects
None yet
Milestone
ECMA builtins
Development

Successfully merging this pull request may close these issues.
5 participants
@dbatyai @egavrin @ruben-ayrapetyan @kkristof @galpeter