New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Number.prototype.toPrecision() #238
Implement Number.prototype.toPrecision() #238
Conversation
|
||
if (is_negative) | ||
{ | ||
ecma_string_t *neg_str_p = ecma_new_ecma_string ((const ecma_char_t *) "-"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add magic string for this?
Good to me. |
Looks good to me. |
int digit = 0; | ||
|
||
/* 10.c, Exponential notation.*/ | ||
if (exponent < -5 || exponent > precision) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are two space: exponent < -5
|
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
lgtm |
|
merged: 713b433 |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com