Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targets: zephyr: Remove old option from prj.conf #2396

Merged
merged 1 commit into from Jun 13, 2018

Conversation

pfalcon
Copy link
Contributor

@pfalcon pfalcon commented Jun 13, 2018

CONFIG_CONSOLE_HANDLER_SHELL is an old option which was removed quite
some time ago from Zephyr. (And newer versions will warn/error on
usage on such options.)

JerryScript-DCO-1.0-Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org

CONFIG_CONSOLE_HANDLER_SHELL is an old option which was removed quite
some time ago from Zephyr. (And newer versions will warn/error on
usage on such options.)

JerryScript-DCO-1.0-Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org
@pfalcon
Copy link
Contributor Author

pfalcon commented Jun 13, 2018

Without this patch, building with the latest Zephyr master (1.13-pre-pre-pre) fails with:

Error: Aborting due to non-whitelisted Kconfig warning 'prj.conf:7: warning: attempt to assign the value "y" to the undefined symbol CONSOLE_HANDLER_SHELL'.

As seen e.g. in our CI: https://ci.linaro.org/job/lite-aeolus-jerryscript/PLATFORM=qemu_x86,ZEPHYR_GCC_VARIANT=zephyr,label=docker-xenial-amd64-13/351/console

Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit 49c79e4 into jerryscript-project:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants