Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Math functions #33

Closed
wants to merge 1 commit into from
Closed

Added Math functions #33

wants to merge 1 commit into from

Conversation

tczene
Copy link

@tczene tczene commented May 11, 2015

JerryScript-DCO-1.0-Signed-off-by: Tamás Czene tczene.u-szeged@partner.samsung.com

@tczene
Copy link
Author

tczene commented May 11, 2015

I could only tested it on x86_64 linux, because i have no other hardware.

@sand1k
Copy link
Contributor

sand1k commented May 13, 2015

Could you, please, run make precommit -j and share the output?

I've concerns that this will not work on stm32, because it only supports single precision floating point format, not double. It seems that the DOUBLE_TO_ECMA_NUMBER_T macro should be implemented manually as low-level function.

Please, move jerry-fdlibm folder to third-party/fdlibm.

@tczene
Copy link
Author

tczene commented May 18, 2015

make precommit -j

Building...

make[1]: Entering directory ' make[1]: Leaving directory'

================ Build completed successfully. Running precommit tests ================

All targets were built successfully. Starting unit tests' run.

make[1]: Entering directory `'

Running ./build/bin/unittests/unit_test_api... OK
Running ./build/bin/unittests/unit_test_heap... OK
Running ./build/bin/unittests/unit_test_number_to_string... OK
Running ./build/bin/unittests/unit_test_pool... OK
Running ./build/bin/unittests/unit_test_poolman... OK
Running ./build/bin/unittests/unit_test_preparser... OK
Running ./build/bin/unittests/unit_test_string_to_number... OK
make[1]: Leaving directory `'

Unit tests completed successfully. Starting full testing.

Full testing completed successfully

@egavrin
Copy link
Contributor

egavrin commented May 18, 2015

Great, make push

JerryScript-DCO-1.0-Signed-off-by: Tamas Czene tczene.u-szeged@partner.samsung.com
@galpeter
Copy link
Contributor

Rebased & merged in: 7dfbc88
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants