Fix assignment lookahead in parser_process_group_expression #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 2, 2020
Closed
zherczeg
reviewed
Jun 2, 2020
| if (context_p->token.type == LEXER_ASSIGN) | ||
| #if ENABLED (JERRY_ES2015) | ||
| if (context_p->token.type == LEXER_ASSIGN | ||
| && parser_is_assignment_expr (context_p)) |
There was a problem hiding this comment.
What about limiting this to identifiers?
rerobika
force-pushed
the
fix_issue_3815
branch
3 times, most recently
from
a7796a1
to
34c9833
Compare
zherczeg
reviewed
Jun 3, 2020
| parser_append_binary_single_assignment_token (context_p, flags); | ||
| lexer_next_token (context_p); | ||
| return true; | ||
| /* Lookahead for anonymous function declatartion after '=' token when the assignment base is LHS expression |
This patch fixes jerryscript-project#3815 and fixes jerryscript-project#3819. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #3815.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu