Python debugger support for Python 3 (in addition to Python 2) #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmedico
force-pushed
the
jerry-debugger-support-python3-in-addition-to-python2
branch
3 times, most recently
from
41e59b1
to
484fbe9
Compare
zmedico
force-pushed
the
jerry-debugger-support-python3-in-addition-to-python2
branch
2 times, most recently
from
99bab4c
to
5961da7
Compare
galpeter
requested changes
Jun 14, 2021
There was a problem hiding this comment.
Have you tried running the debugger tests? ./tools/run-tests.py --jerry-debugger for me this returned various errors which should be also fixed for Python 3.
(I've did a quick hackish changes to resolve some of them: https://gist.github.com/galpeter/a6ac851b6ab113aaad62d60001c5df23 )
zmedico
force-pushed
the
jerry-debugger-support-python3-in-addition-to-python2
branch
from
5961da7
to
622ec35
Compare
I've included your changes, and the debugger tests do pass with them. Thank you! I will look into making you suggested |
- Added safe_ord compatibility to pass through int arguments - Fixed JerryDebugger to decode bytes as utf8 strings when necessary - Fixed WebSocket send_message method to use packed_data[0:1] bytes slice JerryScript-DCO-1.0-Signed-off-by: Zac Medico <zmedico@gmail.com>
zmedico
force-pushed
the
jerry-debugger-support-python3-in-addition-to-python2
branch
from
622ec35
to
22d8b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Zac Medico zmedico@gmail.com