Fix arrow function parsing #5093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
requested changes
Aug 2, 2023
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| class A{} |
There was a problem hiding this comment.
Yes, without it an assertion fails before the bug would cause a segmentation fault:
ICE: Assertion 'context_p->scope_stack_size == PARSER_MAXIMUM_DEPTH_OF_SCOPE_STACK' failed at jerry-core/parser/js/js-parser-expr.c(parser_parse_class):1068
Error: JERRY_FATAL_FAILED_ASSERTION
There was a problem hiding this comment.
Well, this sounds like another bug. Assertions should never fail. Maybe another '}' related bug for classes.
There was a problem hiding this comment.
Oh I was mistaken, I was looking at a different branch.
With this patch applied this assertion does not fail with that line removed and the correct syntax error is raised.
jerry-core/parser/js/js-parser.c
Outdated
| @@ -2829,6 +2829,7 @@ parser_parse_arrow_function (parser_context_t *context_p, /**< context */ | |||
| JERRY_ASSERT (context_p->token.type == LEXER_ARROW); | |||
|
|
|||
| lexer_next_token (context_p); | |||
| bool reached_end_of_function = false; | |||
There was a problem hiding this comment.
I would call this next_token_needed
jerry-core/parser/js/js-parser.c
Outdated
| @@ -2877,6 +2878,10 @@ parser_parse_arrow_function (parser_context_t *context_p, /**< context */ | |||
| #endif /* JERRY_PARSER_DUMP_BYTE_CODE */ | |||
|
|
|||
| parser_restore_context (context_p, &saved_context); | |||
| if (reached_end_of_function) | |||
matetokodi
force-pushed
the
fix_5085
branch
2 times, most recently
from
78824da
to
43640ac
Compare
matetokodi
force-pushed
the
fix_5085
branch
2 times, most recently
from
f577102
to
ae50054
Compare
This fixes jerryscript-project#5085 JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #5085
JerryScript-DCO-1.0-Signed-off-by: Mate Tokodi mate.tokodi@szteszoftver.hu