Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Array.prototype.every() #84

Closed
wants to merge 1 commit into from
Closed

Implemented Array.prototype.every() #84

wants to merge 1 commit into from

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented May 21, 2015

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com

static ecma_completion_value_t
ecma_builtin_array_prototype_object_every (ecma_value_t this_arg, /**< this argument */
ecma_value_t arg1, /**< callbackfn */
ecma_value_t arg2) /**< thisArg */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the 2nd and 3rd be aligned with the first parameter's start?

@ILyoan ILyoan mentioned this pull request May 21, 2015
25 tasks
@galpeter galpeter added this to the ECMA builtins milestone May 21, 2015
@dbatyai
Copy link
Member Author

dbatyai commented May 21, 2015

@galpeter, fixed

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
@galpeter
Copy link
Contributor

lgtm

@dbatyai dbatyai added the ecma builtins Related to ECMA built-in routines label May 22, 2015
@egavrin
Copy link
Contributor

egavrin commented May 27, 2015

make push

@egavrin egavrin self-assigned this May 27, 2015
@dbatyai
Copy link
Member Author

dbatyai commented May 27, 2015

merged: b049998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecma builtins Related to ECMA built-in routines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants