Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intro to iOS] Project 3: Twitter #1

Open
jerrysu opened this issue Oct 1, 2014 · 1 comment
Open

[Intro to iOS] Project 3: Twitter #1

jerrysu opened this issue Oct 1, 2014 · 1 comment

Comments

@jerrysu
Copy link
Owner

jerrysu commented Oct 1, 2014

/cc @thecodepath

@sandofsky
Copy link

Overall, very good. This is one of the homeworks with the least I have to critique.

With subscribing for notifications in the app delegate, you're using selector syntax. I've been moving over to NotificationCenter's block syntax; Apple discourages selector based dispatch, for safety. This seems consistent with other places you've been subscribing for notifications, like the composer.

For notification names, I recommend capitalizing them, e.g. "UserDidLogoutNotification", so they're consistent with iOS naming.

You are creating an NSDateFormatter instance with every status. NSDateFormatter is actually pretty expensive to instance, so it's common to cache a static instance and reuse that through the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants