Add extraInitContainers to Helm chart configuration #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct changelog PR number and contributor.
Move changelog entry to bottom of the list for chronological ordering.
jertel
requested changes
Mar 22, 2023
| @@ -46,6 +46,10 @@ spec: | |||
| containers: | |||
| {{- if .Values.extraContainers }} | |||
| {{ .Values.extraContainers | toYaml | indent 6}} | |||
| {{- end }} | |||
| initContainers: | |||
| {{- if .Values.extraInitContainers }} | |||
There was a problem hiding this comment.
For consistency with the rest of this helm chart, this if statement should be above the initContainers: line. This will avoid the line being included for most users, since there will not be an initContainer.
…s' into add_extraInitContainer_kubernetes
jertel
approved these changes
Mar 22, 2023
|
Hello @jertel Could you apply those changes in Artifact Hub ? Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to #1140
Checklist
make test-dockerwith my changes.Questions or Comments