Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test code, etc. #354

Merged
merged 6 commits into from Jul 20, 2021
Merged

Add test code, etc. #354

merged 6 commits into from Jul 20, 2021

Conversation

nsano-rururu
Copy link
Collaborator

@nsano-rururu nsano-rururu commented Jul 20, 2021

Description

Add test code

thehive.py
94% → 100%

config.py
69% → 86%

create_index.py
16% → 18%

enhancements.py
82% → 100%

kibana.py
82% → 100%

loaders.py
70% → 71%

util.py
97%→99%

Dockerfile-test

Changed ubuntu version of Dockerfile-test from latest to 21.10.
#351

Remove Python 2.x compatibility code
#349

util.py

Checklist

Questions or Comments

config.py
  69% → 86%

create_index.py
  16% → 18%

enhancements.py
  82%  → 100%

kibana.py
  82% → 100%

loaders.py
  70% → 71%
@nsano-rururu nsano-rururu changed the title Testcode7 Add test code, etc. Jul 20, 2021
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this coverage! Thanks for your hard work!

@jertel jertel merged commit 6a0d2b9 into jertel:master Jul 20, 2021
@nsano-rururu nsano-rururu deleted the testcode7 branch July 20, 2021 17:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants