Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Image Pull Secret to Helm Chart #370

Merged
merged 3 commits into from Aug 3, 2021
Merged

Adding Image Pull Secret to Helm Chart #370

merged 3 commits into from Aug 3, 2021

Conversation

robrankin
Copy link
Contributor

@robrankin robrankin commented Jul 27, 2021

Description

Adding Image Pull Secret to the chart, so we can use private repositories.

Checklist

Questions or Comments

@lepouletsuisse
Copy link
Contributor

I think this PR is linked to this discussion.
However, I think it is still a good idea to be able to set the imagePullSecrets on the deployment itself

@jertel
Copy link
Owner

jertel commented Aug 2, 2021

I agree. Will merge once the changelog is updated. I'll update it myself if no one else gets to it this week.

@robrankin
Copy link
Contributor Author

Updated the changelog. Anything else needed?

@jertel
Copy link
Owner

jertel commented Aug 3, 2021

Thank you! Also check that other thread @lepouletsuisse mentioned in case it might be simpler if your deployments all use the same private image repo.

@jertel jertel merged commit f98869a into jertel:master Aug 3, 2021
@robrankin robrankin deleted the imagePullSecret branch August 17, 2021 15:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants