Adds metric_format_string config to Metric Aggregation rule #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jertel
approved these changes
Aug 15, 2021
iamxeph
deleted the
feature_add_metric_format_string_to_metricaggregation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds metric_format_string optional configuration to Metric Aggregation rule. 'metric_format_string' formats match_body's metric_{metric_agg_key} value supporting both format() and %-formatted syntax.
Checklist
make test-dockerwith my changes.Questions or Comments
After this gets merged, I am going to change 'percentage_format_string' of Percentage Aggregation rule to support format() syntax in addition to old %-formatted syntax to make both 'metric_format_string' and 'percentage_format_string' have consistency.