Make percentage_format_string support str.format() syntax #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jertel
reviewed
Aug 15, 2021
elastalert/ruletypes.py
Outdated
| @@ -1308,3 +1308,9 @@ def percentage_violation(self, match_percentage): | |||
| if 'min_percentage' in self.rules and match_percentage < self.rules['min_percentage']: | |||
| return True | |||
| return False | |||
|
|
|||
| def format_string(self, format_config, target_value): | |||
There was a problem hiding this comment.
What do you think about moving this format_string() into a util class so that it doesn't get repeated here?
There was a problem hiding this comment.
Moved format_string() to util.py and added tests for the function accordingly
…https://github.com/iamxeph/elastalert2 into feature_add_support_format_syntax_to_percentagematch
iamxeph
changed the title
iamxeph
deleted the
feature_add_support_format_syntax_to_percentagematch
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR make percentage_format_string support str.format() syntax in addition to old %-format syntax.
Checklist
make test-dockerwith my changes.Questions or Comments