Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After update from 3.1.0 to 3.2.1 no images are showing #655

Closed
teodorkostov opened this issue Jul 20, 2015 · 14 comments
Closed

After update from 3.1.0 to 3.2.1 no images are showing #655

teodorkostov opened this issue Jul 20, 2015 · 14 comments
Labels

Comments

@teodorkostov
Copy link

I updated only the global roots app and no image assets are showing on the website (project created and working with 3.1.0).

I get an error result in the browser saying "connection refused" to the specific image file.

@danlin
Copy link

danlin commented Jul 20, 2015

same here but with a fresh 3.2.1 project. i move down to 3.1.0 and all works as expected.

@jescalan jescalan added the bug label Jul 21, 2015
@jescalan
Copy link
Owner

Hey guys, really sorry this is happening. We have isolated the bug, it's something very strange in charge, roots' web server. It somehow made it through all the tests for 2-3 levels deep of modules, even through 95% coverage on all of them. Crazy. Either way, this bug will be patched up within the next week, for now you can stay on 3.1.x. Really sorry that this happened, and will update here personally as soon as it's fixed and a patch release is out!

🙇

@danlin
Copy link

danlin commented Jul 29, 2015

3.2.2 Still have this bug.
Running in Production works.
The bug is based on this middeware https://github.com/samccone/infestor
Without content replacement all works fine.

@jescalan
Copy link
Owner

Ah thanks for digging this up. This is strange, as the version of infestor is the same as 3.1.x in 3.2.2, so I'm having trouble seeing why it would act differently. I'll dig into it a little further though when I have a minute!

@dbox
Copy link

dbox commented Aug 4, 2015

Can verify happening in 3.2.2

@jag20101
Copy link

jag20101 commented Aug 5, 2015

^ Yup. Running into the same problem :/

@CalvinLeGassick
Copy link

Am experiencing on 3.2.2, can confirm.

@jescalan
Copy link
Owner

jescalan commented Aug 6, 2015

Hey there everyone!

So I think I have this issue worked out. I've applied a fix and tested it on one project that I was having issues with and it worked. However, I'd like to make sure that I really have this right before publishing this next patch.

For anyone that has an example project showing the issue, could you link me up to this project and/or share it with me so I can test it and make sure everything is resolved?

@danlin
Copy link

danlin commented Aug 6, 2015

@Jenius i don't know how other systems handle transfer-encoding: chunked header. On my Mac OS X System with Safari i have broken connections on every Image file and other strange things happening like missing text.

with my infestor patch i have no issues anymore.

@teodorkostov
Copy link
Author

I cannot share the project with you but I can test out the patches myself.

@dbox
Copy link

dbox commented Aug 7, 2015

I'm not even sure you need a sample project. I assume all 3.2.2 projects have broken images.

Here's a repo:

https://github.com/dbox/roots-image-test

Image worked in 3.1.0. Upgraded globally to 3.2.2 and image was broken.

@jescalan
Copy link
Owner

Still working on fixing this guys. Sorry for the delays!

@molovo
Copy link

molovo commented Dec 9, 2015

@Jenius did you get anywhere with this? If you haven't I might take a look under the hood

@dbox
Copy link

dbox commented Dec 9, 2015

@molovo Yes, it's fixed here: #681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants