Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all dependencies #680

Closed
wants to merge 3 commits into from
Closed

update all dependencies #680

wants to merge 3 commits into from

Conversation

jescalan
Copy link
Owner

Some were in dire need of an update. Also get tests running on the latest version of node. Whoo!

@jescalan
Copy link
Owner Author

Ok so all the tests here are passing. This is good. The only thing that needs to be ironed out is whether the weird image clipping issue is occurring still.

@dbox
Copy link

dbox commented Sep 28, 2015

You mean #655? I posted a test repo in there you can check against.

@jescalan
Copy link
Owner Author

Can confirm that the image issue is present. This really needs to be worked out in order for roots to move forward at all. I am going to start hacking on this with any free time I have.

@dbox
Copy link

dbox commented Sep 28, 2015

And there was much rejoicing.

Thanks!! You're the best.

@jescalan
Copy link
Owner Author

Unfortunately I have very little free time, but I'll do my best!

@jescalan
Copy link
Owner Author

Just did a small test and this should fix #659 🎉

@dbox
Copy link

dbox commented Sep 28, 2015

😮 😮 🎉

@dbox
Copy link

dbox commented Sep 28, 2015

were you able to isolate something that was throwing roots segmentation fault ?

@jescalan
Copy link
Owner Author

yeah i had one project that would consistently throw it, after this upgrade it no longer is

@jescalan
Copy link
Owner Author

Ok, can confirm that the broken image issue is coming from the livereload system, specifically from infestor, ironically. If this is disabled, images work correctly. Will have a fix ready for this soon, then we can push out the release!

@jescalan jescalan mentioned this pull request Sep 29, 2015
@jescalan
Copy link
Owner Author

jescalan commented Feb 9, 2016

Browsersync merge takes care of this 🎉

@jescalan jescalan closed this Feb 9, 2016
@jescalan jescalan deleted the deps branch February 9, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants