spawnAsync blocks

[trim21]

flood/server/util/diskUsageUtil.ts

Lines 7 to 14 in 5e6d5c3

	const spawnAsync = (cmd: string, args: string[], options: SpawnSyncOptions): Promise<string> =>
	new Promise((resolve, reject) => {
	const {stdout, error} = spawnSync(cmd, args, options);
	if (error) {
	reject(error);
	return;
	}

this didn't do anything Async, spawnSync will block event loop when executing this command.

ref:

https://nodejs.org/en/docs/guides/dont-block-the-event-loop/

In a server, you should not use the following synchronous APIs from these modules:
...
Child process:
child_process.spawnSync
...

here is a promise example of spawn API

import {spawn} from 'child_process';
// *** Not async
export default function clone(options: { url: string; path: string; }) {
  // *** Return the promise
  return new Promise(function (resolve, reject) {
    const url = options.url;
    const target = options.path;
    const args = ['clone', url, target];
    const process = spawn('git', args);
    process.on('close', function (code) { // Should probably be 'exit', not 'close'
      // *** Process completed
      resolve(code);
    });
    process.on('error', function (err) {
      // *** Process creation failed
      reject(err);
    });
  });
}