Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move torrent function broken in master #42

Closed
3 tasks done
GitHubGeek opened this issue Sep 27, 2020 · 4 comments
Closed
3 tasks done

Move torrent function broken in master #42

GitHubGeek opened this issue Sep 27, 2020 · 4 comments

Comments

@GitHubGeek
Copy link

Type: Bug Report

  • Try to follow the update procedure described in the README and try again before opening this issue.
  • Please check the F.A.Q..
  • Please check the Troubleshooting wiki section.

Your Environment

  • Version used:
    • Commit ID (development release) ab42dae2786c6c40835cf95cb64dbec7176a4dc8
  • Environment name and version:
    • Node.js version v14.12.0
    • npm version 6.14.8
    • Web browser Chrome 84
  • Operating System and version: ubuntu 18.04
  • rTorrent version: rTorrent-PS-CH 1.8.3 0.9.8/0.13.8

Summary

Set Torrent Location dialog moves torrents to an unexpected dir

Expected Behavior

Torrents should be moved to the dir specified in the dialog

Current Behavior

When moving torrents using the Set Torrent Location dialog, torrents were moved to ~/flood/undefined/ where ~/flood is the src install dir

Possible Solution

Steps to Reproduce

  1. Install flood from src to ~/flood, connect to existing rtorrent
  2. Right click context menu > Set Torrent Location
  3. Change path from /foo/download to /foo/download2, tick Move Data, click Set Location
  4. Files being moved to ~/flood/undefined instead of /foo/download2

Context

@jesec
Copy link
Owner

jesec commented Sep 28, 2020

Resolved by d19f148. Please verify.

@GitHubGeek
Copy link
Author

GitHubGeek commented Sep 29, 2020

Tested the function in the latest version afcabb9. Data was moved to the right dir 👍 Thank you for the quick fix!

Side node: Ticked "Check Hash" in the dialog and got this in the terminal:

(node:31154) UnhandledPromiseRejectionWarning: TypeError: hashes.filter is not a function
    at ClientRequest.checkHash (/tank/rtorrent/flood/dist/index.js:121150:34)
    at ClientRequest.checkHash [as onCompleteFn] (/tank/rtorrent/flood/dist/index.js:121774:26)
    at ClientRequest.handleSuccess (/tank/rtorrent/flood/dist/index.js:121066:12)
    at /tank/rtorrent/flood/dist/index.js:121236:9
    at Array.forEach (<anonymous>)
    at ClientRequest.moveTorrents (/tank/rtorrent/flood/dist/index.js:121216:17)
    at ClientRequest.moveTorrents [as onCompleteFn] (/tank/rtorrent/flood/dist/index.js:121785:27)
    at ClientRequest.handleError (/tank/rtorrent/flood/dist/index.js:121052:12)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(node:31154) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:31154) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@jesec
Copy link
Owner

jesec commented Sep 29, 2020

moveTorrents function has been refactored in 912c66d. Please verify if the issue is resolved.

@GitHubGeek
Copy link
Author

Tested on 7890ab7 - Set Torrent Location dialog works as expected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants