client: add CMD-A, CTRL-A to select all torrents #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 57 57
Lines 9211 9211
Branches 909 908 -1
=======================================
Hits 7243 7243
Misses 1957 1957
Partials 11 11 Continue to review full report at Codecov.
|
|
Good idea. I move the event handler to the list component, and attach it to the entire window. I think that would make it more consistent. The PR works fine for me so far. Please test and let me know when it is good to go. |
| @@ -47,6 +49,15 @@ const TorrentList: FC = observer(() => { | |||
| return dispose; | |||
| }, []); | |||
|
|
|||
| useEvent('keydown', (e: KeyboardEvent) => { | |||
| const {repeat, metaKey, ctrlKey, key} = e; | |||
| if (repeat) return; | |||
There was a problem hiding this comment.
const { target } = e;
if (['INPUT', 'TEXTAREA'].includes(target.tagName)) return;
As it's moved to window, make an exception here, so users can still select all text on <input> and <textarea>
|
Tested, works great. Thanks for the updated code. Left one comment. |
Description
After the user selected a torrent, user can use
CMD-AorCTRL-Ato select all torrents. Click one torrent to deselect all. Very useful for bulk editing large collection of torrents.For #122 (reply in thread)
Types of changes