Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sidebar filter sections collapseable #519

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

FinalDoom
Copy link
Contributor

Makes sidebar filter sections collapseable by clicking the title. Since filter lists can get quite long, scrolling down to the tracker list or whichever can be tedious. Simple chevron/carat indicator hides filter section children.

image

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #519 (c814d7e) into master (ce4b523) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   71.96%   72.07%   +0.10%     
==========================================
  Files          61       61              
  Lines       11227    11227              
  Branches      712      716       +4     
==========================================
+ Hits         8080     8092      +12     
+ Misses       3147     3135      -12     
Impacted Files Coverage Δ
server/services/notificationService.ts 52.75% <0.00%> (-1.58%) ⬇️
server/models/Users.ts 97.04% <0.00%> (+0.98%) ⬆️
server/util/feedUtil.ts 46.06% <0.00%> (+13.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4b523...c814d7e. Read the comment docs.

@mouzzampk2014
Copy link

mouzzampk2014 commented Feb 20, 2022

If its possible instead of collapsing all, UI wise might be idea that after 10 or 15 trackers there will be a more at the end.

@FinalDoom
Copy link
Contributor Author

Probably doable simply enough @mouzzampk2014 . I'll keep it in mind when I feel like working on stuff again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants