Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use relative path in mediainfo info #657

Merged
merged 7 commits into from
Nov 29, 2023

Conversation

trim21
Copy link
Collaborator

@trim21 trim21 commented Jul 27, 2023

Description

make mediainfo generate info with relative path starts from torrent directory instead of absolute path, avoid leaking unexpected info.

previous:

General
Complete name                            : /abs/path/to/filename
...

after:

General
Complete name                            : filename
...

Related Issue

Screenshots

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4dd536) 77.08% compared to head (cc329fb) 77.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   77.08%   77.09%           
=======================================
  Files          61       61           
  Lines       11313    11313           
  Branches     1283     1284    +1     
=======================================
+ Hits         8721     8722    +1     
+ Misses       2578     2577    -1     
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/routes/api/torrents.ts Outdated Show resolved Hide resolved
@trim21 trim21 enabled auto-merge (squash) November 29, 2023 05:59
@trim21 trim21 merged commit 572ce1e into jesec:master Nov 29, 2023
12 checks passed
@trim21 trim21 deleted the mediainfo-use-relative-path branch December 9, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant