Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shuffle_train variable might break the code #2

Closed
jeslago opened this issue Jun 30, 2020 · 0 comments
Closed

shuffle_train variable might break the code #2

jeslago opened this issue Jun 30, 2020 · 0 comments

Comments

@jeslago
Copy link
Owner

jeslago commented Jun 30, 2020

At the moment, the code only works if the same value for shuffle_train is used in hyperopt and recalibration. Ideally, one would use shuffle_train=0 for hyperopt and shuffle_train=1 for recalibration or shuffle_train=1 for hyperopt and shuffle_train=1 for recalibration.

The first option is currently not supported. Best option is to remove the dependency of shuffle_train for recalibration as it is always 1, but leave it as input to represent the value of shuffle_train during hyperopt.

jeslago added a commit that referenced this issue Jun 30, 2020
@jeslago jeslago closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant