-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on build using Mac OS #14
Comments
Hi, Thanks for reporting the issue, I don't have a Mac system here, but I recently accepted a pull request for removing Qt Script for some of the build process as it is now deprecated - can you try to remove the remaining references and retry the build? In qmlfmt/QtCreator/CMakeLists.txt: |
Thanks for answering! I tried what you've suggested me. The previous error disappeared but I get a new one at the end:
Sorry I'm not an expert about building C++ apps. |
Hmm, could be a newer/older version of Qt that I have not tested with, what version are you using? |
It uses the Qt 5.5.1 version. I can try with a 5.12 version. |
Sorry, I used the wrong terminal, I was already using the 5.12 version:
|
I can see that the build automation only builds with 5.10 at the moment, I will take a look at getting it working with Qt 5.12 this week- my guess is that is the reason it does not build. |
Ok, I'm going to install the 5.10 version. I've just tested with the 5.5.1, but it doesn't work too. |
Argh, not better with the 5.10.1 version, same error. 😞 |
The problem should come from this line: Line 108 in 955e19d
|
My guess is that this is just the first place that triggers the dependency for the reformatting library - if you remove that line it will just fail the next place that uses the reformatter. I am working on setting up continuous integration for a clang build, I hope that will uncover what the issue is. |
I have created a new branch built on qt creator 4.8.1, can you try that one out? I have also set up a clang build on it, and it passes, so at least that is not the source of the issue. |
I got an error on the
Do you know what it means? |
You need to call git submodule update --init
…On Mon, 4 Feb 2019, 14.37 Nicolas Bazille ***@***.*** wrote:
I got an error on the cmake command:
CMake Error at qmljs/CMakeLists.txt:66 (list):
list sub-command REMOVE_ITEM requires two or more arguments.
Do you know what it means?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEyLkYddFoK3VJ1_1xLHrT0H3HFvWqA-ks5vKDebgaJpZM4aXyYX>
.
|
Ok, thanks, I never use this. |
Sorry, but still some errors:
|
If it can help:
|
I think I found some of the issue at least - missing include of .mm files. Can you try again in the submodule branch? ..you need to rerun CMake configure as I have added some new files ..I updated it some more, missing mac specific frameworks |
I still get this kind of errors but this time more 😞
|
And you have the version where I added:
In qmljs/QMakeLists.txt? |
Sorry I tried with the previous commit. I got this error on
|
Good news, I make some changes and it finally worked! -target_link_libraries(utils PRIVATE Qt5::Widgets Qt5::Network Qt5::Concurrent Qt5::Qml)
+# target_link_libraries(utils PRIVATE Qt5::Widgets Qt5::Network Qt5::Concurrent Qt5::Qml)
if(WIN32)
target_link_libraries(utils PRIVATE user32 iphlpapi ws2_32 shell32)
endif()
if (APPLE)
find_library(AppKit AppKit)
find_library(Foundation Foundation)
- target_link_libraries(utils ${AppKit} ${Foundation})
+ # target_link_libraries(utils ${AppKit} ${Foundation})
+ target_link_libraries(utils PRIVATE Qt5::Widgets Qt5::Network Qt5::Concurrent Qt5::Qml ${AppKit} ${Foundation})
endif() |
Great! I think it would be enough to just add "PRIVATE" to the line:
So I will integrate that in this changeset |
Thanks @jesperhh for investigating and fixing! |
Hello,
I try to build your tool but I meet some troubles. After cloning your repo, I launched this two commands:
An error appear on the second one:
Details
Environment:
The text was updated successfully, but these errors were encountered: