Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gs): Broadcast state by viewports #136

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix(gs): Broadcast state by viewports #136

merged 1 commit into from
Dec 2, 2023

Conversation

splixcord
Copy link
Contributor

Continuation of #120, required #133 first

jespertheend
jespertheend approved these changes Dec 1, 2023
View reviewed changes
Copy link
Owner

@jespertheend jespertheend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
Just out of curiosity, was there anything specifically fixed by this?

@splixcord
Copy link
Contributor Author

A few people saw paused red unnameds that only exist on the client (unable to be killed and they stay in the client's viewport even when far away)
I've only ever seen it twice and I'm unable to replicate but I think broadcasting position when not in viewport is the only thing that potentially causes this

@jespertheend jespertheend merged commit c8ff395 into jespertheend:main Dec 2, 2023
1 check passed
@splixcord splixcord deleted the fix/broadcastplayerevents2 branch December 2, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespertheend jespertheend jespertheend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@splixcord @jespertheend