Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve equity curve readability #391

Merged
merged 1 commit into from May 19, 2023
Merged

improve equity curve readability #391

merged 1 commit into from May 19, 2023

Conversation

movy
Copy link
Contributor

@movy movy commented Jan 19, 2023

Saleh,
I collate Jesse's backtest / walk forward results into a spreadsheet, and exsting equity curve was very faint when downscaling to fit into a cell. I somewhat improved it to be more readable, hope it's useful for others.

Changes:

  • equity curve linewidth = 4,
  • added green/red fills for above / underwater periods

Before:
https://www.dropbox.com/s/ibp2owkbo8fikem/93308f1d-cbf9-43bf-aede-bba35f830997.png?dl=0

After:
https://www.dropbox.com/s/pgjipxr5lvy16v3/3e278f87-6b8d-4f95-9d73-fe5dde6e3d5e.png?dl=0

Saleh,
I collate Jesse's backtest / walk forward results into a spreadsheet, and exsting equity curve was very faint when downscaling to fit into a cell (see screenshots below). I somewhat improved it to be more readable, hope it's useful for others.

Changes:
- equity curve linewidth = 4, 
- added green/red fills for above / underwater periods

Before:
https://www.dropbox.com/s/ibp2owkbo8fikem/93308f1d-cbf9-43bf-aede-bba35f830997.png?dl=0

After:
https://www.dropbox.com/s/pgjipxr5lvy16v3/3e278f87-6b8d-4f95-9d73-fe5dde6e3d5e.png?dl=0
@stale
Copy link

stale bot commented Mar 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent activity. label Mar 20, 2023
@stale stale bot closed this Mar 27, 2023
@saleh-mir
Copy link
Member

This is awesome. Thank you!

@saleh-mir saleh-mir reopened this May 19, 2023
@saleh-mir saleh-mir merged commit 3fd5f00 into jesse-ai:master May 19, 2023
3 checks passed
@stale stale bot removed the stale No recent activity. label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants