Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numba now is a mandatory requirement #429

Merged
merged 7 commits into from
Apr 13, 2024
Merged

Conversation

kakulukia
Copy link
Contributor

also added python 3.11 to the test matrix
indicator files have been rearranged with isort as i touched a lot of them

…s and sorted the imports from all indicators using isort

Also activated the arm osx github action .. lets see if it just runs
…or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings."

^^thats why this was disabled? Gitub actions for osc and windows are not for free? :/
@kakulukia
Copy link
Contributor Author

Also added a PR here: jesse-ai/docs#63

…with an optional CSS class for the h3 that is displaying the raise error in the dashboard it could also handle the line breaks which currently only work in the console

needed css in the dashboard: "white-space: pre-line;"
@yakir4123
Copy link
Contributor

great pr!
something that can be added, i've notice there is an overhead for start a simulation with numba vs without numba.
we can cache the compilation time to avoid this overhead!
maybe this can be a good idea to add it too!
https://numba.readthedocs.io/en/stable/user/jit.html#cache

@kakulukia
Copy link
Contributor Author

I certainly can add this cached=True
Do you also have a good idea of how to measure the performance gain? I will have as look at the test performance with our without cache.

@yakir4123
Copy link
Contributor

Ill do 1 or 2 example,
What im going to do is run a simulation of daily timeframe for 1 day. Where the only thing this strategy do is to import several indicators, the imports will do the compilation.

By making the simulation the shortest that possible, the strategy doesnt really needs to do anything.

As i said ill do a comparision myself.
Cheers.

@kakulukia
Copy link
Contributor Author

pytest without cache: 15s first run, 13s follow ups
pytest with cache: 15s first run, 4s follow ups
Commit is added!

@saleh-mir
Copy link
Member

This is indeed a great pull request. Thank you for being careful with Python 3.8 version.

@saleh-mir saleh-mir merged commit c9c0fc1 into jesse-ai:master Apr 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants