Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the warmup candles in front of the test period #435

Merged
merged 11 commits into from
Apr 14, 2024

Conversation

kakulukia
Copy link
Contributor

The normal backtest is already doing that, but the research modules get_candles was missing such functionality.

…s and sorted the imports from all indicators using isort

Also activated the arm osx github action .. lets see if it just runs
…or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings."

^^thats why this was disabled? Gitub actions for osc and windows are not for free? :/
…with an optional CSS class for the h3 that is displaying the raise error in the dashboard it could also handle the line breaks which currently only work in the console

needed css in the dashboard: "white-space: pre-line;"
kakulukia added a commit to kakulukia/project-template that referenced this pull request Apr 10, 2024
added local test script to be able to run multiple test on symbols and time frames at once and find the best one according to a chosen metric value.

All you need to:
. import your strategy
. be sure to import all needed candles
. (un)comment, add, change symbols and time frames as needed

!!! jesse-ai/jesse#435 is a requirement for this test script
@saleh-mir
Copy link
Member

I prefer this idea over my previous one of passing warmup candles directly to the backtesting function. This new approach is simpler: you pass the number, and it provides the candles. If warmup candles are not passed, the function will handle it by splitting them. Just ensure we pass them initially, and it should work fine.

for future pull requests, please make sure that your pull request only includes the change the required code for this functionality It's really difficult for me to go through. It seems like it's been combined with your other previous pull requests.

@saleh-mir saleh-mir merged commit 0786ede into jesse-ai:master Apr 14, 2024
4 checks passed
@kakulukia
Copy link
Contributor Author

Sorry for that!
Next time just tell me to clean it up first. 🙈

@saleh-mir
Copy link
Member

No problem ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants