Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSV dump option for backtester #48

Merged
merged 3 commits into from Jun 27, 2020
Merged

Conversation

techdubb
Copy link
Contributor

  • add file export code
  • add CSV option to backtest CLI

@techdubb
Copy link
Contributor Author

@saleh-mir here is my second attempt. 😄

@saleh-old
Copy link
Contributor

I appreciate your work man. I’ll dive into it as soon as I can.

@saleh-old
Copy link
Contributor

There is no need to store the value in config. Skip that part and send the csv boolean as parameters of functions calls.

@techdubb
Copy link
Contributor Author

Good call. I've updated it accordingly.

@saleh-old saleh-old merged commit af41d1a into jesse-ai:master Jun 27, 2020
@saleh-old
Copy link
Contributor

I'm gonna try it now. Thank you for the PR.

P.S: cool beard! I just couldn't not say anything ;)

@saleh-old
Copy link
Contributor

Just executed it. I love it. I'm gonna modify the column and convert timestamps into human readable and etc. But the main idea works and is very exciting actually. To be able to see trades in excel. Thanks again

@techdubb
Copy link
Contributor Author

Great to see it worked out. And thanks for the comment on the beard... :).

@techdubb techdubb deleted the csv-dump branch June 28, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants