Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew packages being installed even if they are already installed 馃 #91

Closed
jessebot opened this issue Nov 18, 2022 · 5 comments 路 Fixed by #97
Closed

brew packages being installed even if they are already installed 馃 #91

jessebot opened this issue Nov 18, 2022 · 5 comments 路 Fixed by #97
Assignees
Labels
bug Something isn't working 馃惂 Linux 馃崕 macOS

Comments

@jessebot
Copy link
Owner

we should skip installing them if they're already there, because we already handle the upgrade edge case.

@jessebot jessebot added bug Something isn't working 馃崕 macOS labels Nov 18, 2022
@jessebot jessebot self-assigned this Nov 18, 2022
@jessebot jessebot changed the title brew packages being installed even if they are already available 馃 brew packages being installed even if they are already installed 馃 Nov 19, 2022
@jessebot
Copy link
Owner Author

this was happening for apt as well, and it was at least partially because apt list --installed returns output like this:

apt-config-icons/testing,testing,testing,testing,now 0.15.5-1 all [installed,automatic]

But we need it to be just the package name, so we're changing it to apt-cache pkgnames as of #94

@jessebot
Copy link
Owner Author

jessebot commented Nov 25, 2022

part of the issue was rich vs rich-cli. Some other weird package names vs install names I'm currently sorting through as well.

@jessebot
Copy link
Owner Author

jessebot commented Nov 25, 2022

ag vs the_silver_searcher 馃し

@jessebot
Copy link
Owner Author

jessebot commented Nov 26, 2022

this was also caused by package names like --cask iterm2 (for brew) and nvidia-driver-libs:i386 (for apt). I added in some fixes for that in the linked PR. Also did a minor refactor for future me to understand how this package install file even works

@jessebot
Copy link
Owner Author

I can't actually fix the steam:i386 error because we currently use apt-cache pkgnames to look for the packages, and steam doesn't show up there at all. It does show in apt list --installed but I don't feel like it realllly matters for now, because then I'd need another conditional just for steam, and that's getting a bit much.

This has been fixed and tested on both macOS and Linux though (or will be when the above PR is merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 馃惂 Linux 馃崕 macOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant