chore: Preallocate space for slices with known size (argoproj-labs#575)

Signed-off-by: satoru <satorulogic@gmail.com> Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com>
jessebye · Sep 1, 2023 · 31c0152 · 31c0152
1 parent deab5b3
commit 31c0152
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/registry/endpoints.go b/pkg/registry/endpoints.go
@@ -247,9 +247,9 @@ func SetRegistryEndpointCredentials(prefix, credentials string) error {
 
 // ConfiguredEndpoints returns a list of prefixes that are configured
 func ConfiguredEndpoints() []string {
-	r := []string{}
 	registryLock.RLock()
 	defer registryLock.RUnlock()
+	r := make([]string, 0, len(registries))
 	for _, v := range registries {
 		r = append(r, v.RegistryPrefix)
 	}

diff --git a/pkg/tag/tag.go b/pkg/tag/tag.go
@@ -124,7 +124,7 @@ func (il ImageTagList) Add(tag *ImageTag) {
 
 // SortByName returns an array of ImageTag objects, sorted by the tag's name
 func (il ImageTagList) SortAlphabetically() SortableImageTagList {
-	sil := SortableImageTagList{}
+	sil := make(SortableImageTagList, 0, len(il.items))
 	for _, v := range il.items {
 		sil = append(sil, v)
 	}
@@ -136,7 +136,7 @@ func (il ImageTagList) SortAlphabetically() SortableImageTagList {
 
 // SortByDate returns a SortableImageTagList, sorted by the tag's date
 func (il ImageTagList) SortByDate() SortableImageTagList {
-	sil := SortableImageTagList{}
+	sil := make(SortableImageTagList, 0, len(il.items))
 	for _, v := range il.items {
 		sil = append(sil, v)
 	}