Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barely visible texts in terminal running solorized-dark color scheme #63

Closed
den-is opened this issue Jul 2, 2019 · 5 comments · Fixed by #65
Closed

Barely visible texts in terminal running solorized-dark color scheme #63

den-is opened this issue Jul 2, 2019 · 5 comments · Fixed by #65
Labels
bug Something isn't working

Comments

@den-is
Copy link

den-is commented Jul 2, 2019

Describe the bug
Some texts are barely visible in terminal which is using solarized-dark color scheme.
See attachment.

Screenshots
Screen Shot 2019-07-02 at 12 40 13

Desktop (please complete the following information):

  • macos 10.14.5
  • iTerm 3.2.6
lazydocker version
Version: commit=cf31c23fadcc717467318689fc073ecf1bed8031, build date=2019-07-02T00:10:43Z, build source=binaryRelease, version=0.3, os=darwin, arch=amd64

Additional context
similar issues with more screenshots if that helps
derailed/k9s#132
derailed/k9s#197 (comment)

@den-is den-is added the bug Something isn't working label Jul 2, 2019
@den-is den-is changed the title Bad text color for solorized-dark color scheme Barely visible texts in terminal running solorized-dark color scheme Jul 2, 2019
@mjarkk
Copy link
Collaborator

mjarkk commented Jul 2, 2019

Totally agree,
image

@jesseduffield
Copy link
Owner

jesseduffield commented Jul 2, 2019

Yeah I've also seen this on a colleagues computer. It's such a shame because it looks fine on my terminal, but I'm not sure what replacement color I could use. Luckily we already have color-customisable panel borders but as for things like these 'none's:

image

What might be a better option than black? I want them to look kind of out-of-the-way

@jesseduffield
Copy link
Owner

blue doesn't look too bad:
image

image

Blue is usually the darkest of the colors so I think it suits. Just means now we'll need a different color for the container state of 'exited (0)' (I made it blue to distinguish a good exit from a bad exit). Maybe Yellow?

@jesseduffield
Copy link
Owner

here's exited(0) in yellow:
image

I think it looks appropriate

@jesseduffield
Copy link
Owner

PR is up #65

@mjarkk mjarkk closed this as completed in #65 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants