Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting o to open config hangs #71

Closed
mikhailswift opened this issue Jul 2, 2019 · 1 comment
Closed

Hitting o to open config hangs #71

mikhailswift opened this issue Jul 2, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@mikhailswift
Copy link
Contributor

Describe the bug
Hitting o while on the status pane to view my config hangs the app.

To Reproduce
Steps to reproduce the behavior:

  1. Go to status pane
  2. Hit o

Expected behaviour
Config displays

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Arch Linux
  • Lazydocker Version 0.3.0

Additional context
nvim seems to be the app xdg-open chooses to view the config.yml file. I can run xdg-open ~/.config/jesseduffield/lazydocker/config.yml (which seems to be the command lazydocker runs) in a shell to open the config file in nvim successfully. I can also hit e in lazydocker to edit the config and it opens for edit successfully. When I'm not on work hours I can play around with a development build and see if I can determine what is happening.

@mikhailswift mikhailswift added the bug Something isn't working label Jul 2, 2019
@mikhailswift
Copy link
Contributor Author

Root of the issue is my xdg-open is choosing vim, and lazydocker by default routes the output to /dev/null. Running the command sh -c "xdg-open '/home/REDACTED/.config/jesseduffield/lazydocker/config.yml' >/dev/null" (which is what lazydocker chooses to run) causes the output:

Vim: Warning: Output is not to a terminal

Changing lazydocker's config to either remove the redirect to /dev/null or just open nvim {{filename}} results in the same. To get this to work I'd have to use the runSyncOrAsyncCommand similarly to gui.editFile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant