Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to use with light background #9

Closed
unixfile opened this issue Jun 30, 2019 · 7 comments
Closed

Difficult to use with light background #9

unixfile opened this issue Jun 30, 2019 · 7 comments

Comments

@unixfile
Copy link

Much of the text in the UI is close to unreadable with a light background.

Tested with:
xterm -bg lemonchiffon
gnome-terminal (with default settings)

Otherwise it's great on black background.

Cheers!

@jesseduffield
Copy link
Owner

jesseduffield commented Jun 30, 2019

Agreed, it does not look too good on a white background. I think the main issue is that I'm forcing the text to be white in some places when what I really mean is that I want the text to be the default foreground color. I've gone and fixed up a heap of those places, and testing on my end the UI is fairly readable now.

Here's the release with the changes: https://github.com/jesseduffield/lazydocker/releases/tag/v0.2.3

Let me know what you think :)

@gabel
Copy link

gabel commented Jul 3, 2019

@jesseduffield Does 0.3 include the changes?

Basis font looks ok but tabs and border colors are missing

iterm light theme

image

dark theme

image

@mjarkk
Copy link
Collaborator

mjarkk commented Jul 3, 2019

@gabel For the border issue,
You can change the border color in the config: lazydocker > Status > "o"

You could do something like this:

gui:
  theme:
    inactiveBorderColor:
    - black

https://github.com/jesseduffield/lazydocker/blob/master/docs/Config.md

@gabel
Copy link

gabel commented Jul 3, 2019

@mjarkk Thank you that helped! It solves border color and tab font color issues. Might be useful to have something like the invert mode that ctop has.

image

When opening the menu the issue still exists

image

BTW

Status > o gave me

image

But just editing with vim worked.

vim /Users/foobar/Library/Application\ Support/jesseduffield/lazydocker/config.yml

Regarding file open issue... intellij did not bind yml files to open. Installing an editor who does (e.g. VS Code) enabled the o variant as well. 👍

@jesseduffield
Copy link
Owner

I've updated the default config to use the default color on border frames too, so others won't need to update their config for this :)

@unixfile
Copy link
Author

unixfile commented Jul 3, 2019

Thanks, looks great now!

@jesseduffield
Copy link
Owner

Awesome :) closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants