Remove config, make default sort order descending

jesseduffield · Jun 5, 2021 · 94b52af · 94b52af
1 parent 472288c
commit 94b52af
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/docs/Config.md b/docs/Config.md
@@ -44,7 +44,6 @@ gui:
   showRandomTip: true
   showCommandLog: true
   commandLogSize: 8
-  sortTagsDescending: false # sort order for tags
 git:
   paging:
     colorArg: always

diff --git a/pkg/commands/loading_tags.go b/pkg/commands/loading_tags.go
@@ -46,8 +46,8 @@ func (c *GitCommand) GetTags() ([]*models.Tag, error) {
 	// now lets sort our tags by name numerically
 	re := regexp.MustCompile(semverRegex)
 
-	sortAsc := !c.Config.GetUserConfig().Gui.SortTagsDescending
-	// the reason  this is complicated is because we're both sorting alphabetically
+	sortAsc := c.Config.GetUserConfig().Gui.SortTagsAscending
+	// the reason this is complicated is because we're both sorting alphabetically
 	// and when we're dealing with semver strings
 	sort.Slice(tags, func(i, j int) bool {
 		var a, b string

diff --git a/pkg/config/user_config.go b/pkg/config/user_config.go
@@ -39,7 +39,7 @@ type GuiConfig struct {
 	ShowRandomTip            bool               `yaml:"showRandomTip"`
 	ShowCommandLog           bool               `yaml:"showCommandLog"`
 	CommandLogSize           int                `yaml:"commandLogSize"`
-	SortTagsDescending       bool               `yaml:"sortTagsDescending"`
+	SortTagsAscending        bool               `yaml:"sortTagsAscending"`
 }
 
 type ThemeConfig struct {
@@ -308,7 +308,7 @@ func GetDefaultConfig() *UserConfig {
 			ShowFileTree:             false,
 			ShowRandomTip:            true,
 			CommandLogSize:           8,
-			SortTagsDescending:       false,
+			SortTagsAscending:        false,
 		},
 		Git: GitConfig{
 			Paging: PagingConfig{