New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove yaml fork #2833
Labels
maintenance
For refactorings, CI changes, tests, version bumping, etc
Comments
jesseduffield
added
the
maintenance
For refactorings, CI changes, tests, version bumping, etc
label
Jul 26, 2023
This was referenced Jul 26, 2023
6 tasks
karimkhaleel
added a commit
to karimkhaleel/lazygit
that referenced
this issue
Oct 9, 2023
Treat <disabled> setting as equivalent to "null" in keybindings user configs.
karimkhaleel
added a commit
to karimkhaleel/lazygit
that referenced
this issue
Oct 9, 2023
Treat <disabled> setting as equivalent to "null" in keybindings user configs.
6 tasks
karimkhaleel
added a commit
to karimkhaleel/lazygit
that referenced
this issue
Oct 9, 2023
Treat <disabled> setting as equivalent to "null" in keybindings user configs.
jesseduffield
added a commit
that referenced
this issue
Oct 10, 2023
Fixed by #3459. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a yaml fork which specially handles null values when merging yaml files. This allows us to set a keybinding to null and have it unmapped, rather than being set to the default.
I want to migrate users' configs to instead use
<disabled>
in place ofnull
so that we get the same merging behaviour without needing to use my fork.We can test the behaviour with this integration test:
The text was updated successfully, but these errors were encountered: