Better global error handling #3491
Labels
Comments
This was referenced Apr 11, 2024
stefanhaller
added a commit
that referenced
this issue
Apr 18, 2024
- **PR Description** Simplify and canonicalize error handling across the code base. Previously it was important to make sure that errors don't bubble up into gocui, because it would panic there; so we had to show errors in error panels in the right places (in controller code, usually). This is error-prone because it's easy to forget (see #3490 for an example); also, it's not always obvious where in the call chain the error panel needs to be shown. Most of the time it's in controller code, but we had plenty of calls to `Error()` in helpers, and I remember that I found this very confusing when I was new to the code base. Change this so that you can simply return errors everywhere. The functions to show an error message manually have been removed for clarity. I tried to structure the commits so that you can review them one by one. Closes #3491.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, all entry points into the codebase (e.g. event handlers) need to catch errors and present them in an error panel, so we have tons of calls to
self.c.Error(err)in the controller and helper classes. It's easy to forget this, however, and simply return the error instead, which will cause a panic in gocui (see #3490 for an example).It would be much nicer if we could simply return errors everywhere, and gocui would take care of showing an error box after handling an event that returned an error. To do this
gocui.Guijust needs an error callback, this seems very easy (see also the last paragraph of this long comment, starting with "As for surfacing the error..."). It seems we could then hopefully get rid ofIPopupHandler.Error.The text was updated successfully, but these errors were encountered: