Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when commit message contains more than one word (space separated) on Windows 10 #620

Closed
no-realm opened this issue Feb 1, 2020 · 0 comments · Fixed by #860
Closed
Labels
bug Something isn't working

Comments

@no-realm
Copy link
Contributor

no-realm commented Feb 1, 2020

Describe the bug
Commit messages with more than one word fail with the error below.

+ cmd /c git commit  -m \"test1 test2\"

error: pathspec 'test2\"' did not match any file(s) known to git

Press enter to return to lazygit

And commit messages with one word have incorrect commit messages (when viewed later):

\"test1 test2\"

To Reproduce
Steps to reproduce the behavior:

  1. Download or compile lazygit
  2. Open repo with lazygit (in either cmd or powershell)
  3. Change a file and stage the change
  4. Commit with a commit message that has more than one word (space separated)

Expected behavior
Support commit messages with more than one word.
Correctly formatted commit messages.

Desktop (please complete the following information):

  • OS: Windows 10 64-bit
  • Lazygit Version v0.13 (prebuilt from releases) and commit below
  • c173ebf

Additional context
Looks very similar to a previously closed issue #141.

@no-realm no-realm added the bug Something isn't working label Feb 1, 2020
no-realm added a commit to no-realm/lazygit that referenced this issue May 30, 2020
fixes jesseduffield#620

Signed-off-by: Randshot <randshot@norealm.xyz>
jesseduffield pushed a commit that referenced this issue Jul 12, 2020
fixes #620

Signed-off-by: Randshot <randshot@norealm.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant