Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve command execution with strange file names. #1177

Merged
merged 5 commits into from Mar 13, 2021

Conversation

Ryooooooga
Copy link
Contributor

@Ryooooooga Ryooooooga commented Mar 2, 2021

Fixed a problem where some commands would fail if the file name contained spaces, ", or multibyte characters (without git config core.quotePath false).

related: #378

  • " in a filename (left: PR, right: master)

スクリーンショット 2021-03-02 12 58 06

  • then, when we type space, git add ... will fail (master)

スクリーンショット 2021-03-02 13 19 24

  • a filename starting with - (left: PR, right: master)

スクリーンショット 2021-03-02 12 58 23

  • multibyte characters (left: PR, right: master)

スクリーンショット 2021-03-02 12 58 48

  • in history (left: PR, right: master)

スクリーンショット 2021-03-02 13 04 30

@Ryooooooga Ryooooooga marked this pull request as ready for review March 2, 2021 04:42
@jesseduffield
Copy link
Owner

tested locally and works like a charm. Nice work @Ryooooooga !

@jesseduffield jesseduffield merged commit 3d698cd into jesseduffield:master Mar 13, 2021
@Ryooooooga Ryooooooga deleted the multibyte-filename branch March 13, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants